Skip to content

Zulip test needs to migrate to wide gamut flutter_color_models fork #154123

@gaaclarke

Description

@gaaclarke

Description

Part of the work of introducing wide gamut color to the framework is editing the Color API. That change got reverted because it is breaking customer test Zulip. The problem isn't the Zulip test per se, but a dependency of theirs, flutter_color_model (and its dependency color_model).

I've filed an issue with the color_model developer and posted a PR for them that fixes the issue. I haven't heard back from them yet though.

I need the Zulip test to migrate to the forked flutter_color_model and color_model or it will be disabled in 72 hours (as per our SLA).

I'm sending an email to the 2 listed contacts for that test too.

Remedy

The Zulip test will have to add dependency_overrides for the following packages: flutter_color_models, color_models.

The overrides are going to point to my branch, wide-gamut. You use the git directives in pubspec to point it to that fork. Those 2 packages also live in the same repo, so the ref and path directives will have to be used.

That fork of color_models is a breaking change so there may be some required changes in the Zulip test, but probably not. The changes can be found in the CHANGELOG.md for those packages.

Another option would just be to eliminate the dependency on flutter_color_models.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions