Skip to content

Update run_verify_binaries_codesigned_tests to collect and print all the missing/unexpected binaries on failure, instead of failing-fast on the first #154029

New issue
New issue
Open
Open
Update run_verify_binaries_codesigned_tests to collect and print all the missing/unexpected binaries on failure, instead of failing-fast on the first#154029
Labels
P2Important issues not at the top of the work listinfra: releaseRelease-related requests and toolingteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team
@jmagman

Description

@jmagman
jmagman
opened on Aug 23, 2024

This was an issue in #153787.

@itsjustkevin asks

Is it possible that the test failed only on the first binary?

I think so, based on more binaries missing from the list: #154027

The test should be updated to collect all the unexpected binaries, and print them all:

flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart

Lines 150 to 152 in 5e19438

for (final String binaryPath in binaryPaths)
if (allExpectedFiles.contains(binaryPath)) binaryPath
else throw Exception('Found unexpected binary in cache: $binaryPath'),

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listinfra: releaseRelease-related requests and toolingteam-infraOwned by Infrastructure teamtriaged-infraTriaged by Infrastructure team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions