-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
f: cupertinoflutter/packages/flutter/cupertino repositoryflutter/packages/flutter/cupertino repositoryf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamOwned by Design Languages team
Description
Hello everyone!
I somehow stumbled on this PR and I noticed this PR adds `requestFocus` parameter to classes/widgets other than related to PopupMenuButton such as bottom sheet, dialog, transition route, overlay route but doesn't test them.
It makes it possible to remove some of the `requestFocus` parameters from this PR without failing any tests in the framework.
If anyone is interested in writing tests, please let me know. If not, I'd be happy to write those missing tests.
Originally posted by @TahaTesser in #150568 (comment)
Metadata
Metadata
Assignees
Labels
f: cupertinoflutter/packages/flutter/cupertino repositoryflutter/packages/flutter/cupertino repositoryf: material designflutter/packages/flutter/material repository.flutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamOwned by Design Languages team
Type
Projects
Status
Done (PR merged)