-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Otherwise we will not accurately capture scales that are < 1.
See discussion in flutter/engine#54368 (comment)
I think so. Determinant of 2D matrices is the area of the (transformed) unit square which is pretty much the same thing, but it combines them geometrically so 2x in one direction balances 0.5 in the other. But matrix is a 3D thing so it becomes volume of the unit cube which might not be what we want. Or maybe it's OK since the volume of the cube is the area of the square times the height which is 1.0 - but still it will combine scales between the directions which is not what we want.
So, I think MaxBasisXY is a better value to use.
Really in all of these cases we should be doing separated 2D measurements rather than using the "max" or determinant. We should independently clamp each dimension separately.