-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Closed
Copy link
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regression
Description
Starting with #153148, which contains only the Dart -> Engine roll with commits: https://dart.googlesource.com/sdk.git/+log/9222e4c96f4d..1cc09f3f3642, the engine is failing to roll to the framework. The failures are in Flutter CLI tests that check strings emitted on streams match expected values as in:
It looks like the change that led to this was: https://dart.googlesource.com/sdk.git/+/e8c035308bec001af477d644f3a5c396dedc94ff
cc @a-siva.
I think we could probably just update the string expectations of the tests in the framework.
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regression