Skip to content

Enable dart analyze for all of flutter/engine #152636

@matanlurey

Description

@matanlurey

I asked on an internal chat:

Is there a (good) reason (TM) that only a subset of the flutter/engine is analyzed by dart analyze:
https://github.com/flutter/engine/blob/8130df28c89df6185f620225644ae297cdf40fe4/ci/analyze.sh#L61-L67

I think with our new workspace config, we can theoretically analyze the root (which needs about 200 diagnostics cleaned up before it can happen). Wdut y'all?

(We would still be able to exclude files via normal means)

@zanderso:

Not that I know of. If some dart code is missing from that list it's an accident.


I'll start burning down the existing diagnostics (~300 of them) as a background task.

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions