-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#54779Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
I asked on an internal chat:
Is there a (good) reason (TM) that only a subset of the
flutter/engineis analyzed bydart analyze:
https://github.com/flutter/engine/blob/8130df28c89df6185f620225644ae297cdf40fe4/ci/analyze.sh#L61-L67I think with our new workspace config, we can theoretically analyze the root (which needs about 200 diagnostics cleaned up before it can happen). Wdut y'all?
(We would still be able to exclude files via normal means)
Not that I know of. If some dart code is missing from that list it's an accident.
I'll start burning down the existing diagnostics (~300 of them) as a background task.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team