-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Description
On this line:
When a semantic node self-identifies as isHeader, the web engine assigns the "heading" role. However, the more appropriate ARIA role would be "banner".
It is also worth revisiting this line:
Currently the GenericRole expects the header to have a label. However, the UI structure could be such that the header is a parent of multiple other semantic elements. See the MDN example that has a <header> containing an <h1> and <time>.
A more complete solution is probably to create a PrimaryRoleManager (to be renamed to SemanticRole in flutter/engine#54070) for header, and stop relying on the GenericRole, which is really just a fallback when we couldn't think of a better role for a node.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work lista: accessibilityAccessibility, e.g. VoiceOver or TalkBack. (aka a11y)Accessibility, e.g. VoiceOver or TalkBack. (aka a11y)engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team