Skip to content

Consider a flutter/flutter/packages/_flutter_common #152257

@matanlurey

Description

@matanlurey

As part of #152194, we discussed there are several sources of duplicated code in the Flutter SDK internals, particularly around things like "working with ADB", "parsing Gradle logs", "understanding exit codes", and "comparing golden files".

One suggestion was the creation of a flutter/flutter/packages/_flutter_common (the actual name should be better if able).

It's not clear what the scope of this package would be, how we would maintain it, who would be responsible for it, and how to stop it devolving from a utils folder, but it's an idea on how to reduce some code duplication. This issue is tracking ideas or suggestions towards that end, and I'll revisit it at the end of Q3 to see if there is a viable path.

/cc @christopherfujino @jonahwilliams @andrewkolos @johnmccutchan @gaaclarke @jmagman @Piinks

Metadata

Metadata

Assignees

Labels

P3Issues that are less important to the Flutter projectc: proposalA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.e: scenario-appThe `testing/scenario_app` fixture in the engineinfra: device labInfrastructure device lab problemst: flutter driver"flutter driver", flutter_drive, or a driver testtoolAffects the "flutter" command-line tool. See also t: labels.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions