Skip to content

[CP] [web] Set touch-action:none in embedded views.  #152047

@ditman

Description

@ditman

Issue Link

flutter/engine#53647

Target

beta

PR Link

flutter/engine#54007

Changelog Description

Applies touch-action:none in embedded views, so Flutter can handle all touch events without interference from the browser. (The previous fix broke certain a11y taps).

Impacted Users

Flutter web mobile users with semantics enabled.

Impact Description

When semantics are enabled, tapping on the label of a checkbox in a mobile browser won't togle the checkbox. It's also harder for screen reader users to access those component+label "merged" widgets.

Workaround

No, because the old solution was intercepting some pointer events that turns out were needed in certain cases.

Risk

low

Test Coverage

yes

Validation Steps

It's been validated in the original PR, but a way of validating is by running the app listed here:

Deploying it somewhere and attempting to click in the "A checkbox" label, with chrome in "responsive mode, with taps enable". Before the fix, the click won't do anything. After the fix, the click will toggle the checkbox.

/cc @yjbanov

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions