-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Issue Link
Target
beta
PR Link
Changelog Description
Applies touch-action:none in embedded views, so Flutter can handle all touch events without interference from the browser. (The previous fix broke certain a11y taps).
Impacted Users
Flutter web mobile users with semantics enabled.
Impact Description
When semantics are enabled, tapping on the label of a checkbox in a mobile browser won't togle the checkbox. It's also harder for screen reader users to access those component+label "merged" widgets.
Workaround
No, because the old solution was intercepting some pointer events that turns out were needed in certain cases.
Risk
low
Test Coverage
yes
Validation Steps
It's been validated in the original PR, but a way of validating is by running the app listed here:
Deploying it somewhere and attempting to click in the "A checkbox" label, with chrome in "responsive mode, with taps enable". Before the fix, the click won't do anything. After the fix, the click will toggle the checkbox.
/cc @yjbanov