Skip to content

[Impeller] display list and aiks disagree on what an unbounded save layer's coverage should be #151785

@jonahwilliams

Description

@jonahwilliams

Display List uses kMaxCullRect, while Aiks expects a std::nullopt coverage. Right now if Aiks gets a saveLayer with a kMaxCullRect it does not attempt to shrink it down, which can lead to texture allocation failures, see: https://github.com/flutter/engine/pull/53792/files#diff-5a218818fd81dbcb1c774b01b49484cb05613d2540b4d50d55228e9bcdbfa7bbR38 which needs a cull rect otherwise it fails to render.

This isn't specifically related to experimental canvas, but was noticed while migrating tests to display list. This problem impacts both aiks/entity pass and experimental canvas.

FYI @flar

Metadata

Metadata

Assignees

No one assigned

    Labels

    e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.team-engineOwned by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions