You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Impeller] Wire up Angle with playgrounds on all platforms. #151353
When I tried to wire this up on Windows and Linux, I ran into issues with static linking of Angle with GLFW as GLFW doesn't seem to comprehend that Angle can be linked statically.
When I tried to setup Angle to be linked dynamically, Angle was sad when compiling the Vulkan adapter (which is not needed on macOS) because of the way Flutter compiles its own VMA. When compiling statically, Angle can use our VMA. But it misses those symbols when compiling dynamically.
Either GLFW should be patched to work with a statically linked Angle or we should figure out our rules on making Angle have access to a VMA when linking dynmaically.
If you look through the GN files for angle there doesn't seem to be a place where it ever specifies VMA as a dependency. There is some references to what version they'd like to use and there is some references to the fact that Angle uses a fork of VMA in //doc/BranchingAndRolling.md Here's some example output I get when trying to link angle on linux:
Okay, I think I know what's going on. VMA is kind of a weird library, you have to declare VMA_IMPLEMENTATION and include the header in one cc file (https://gpuopen-librariesandsdks.github.io/VulkanMemoryAllocator/html/quick_start.html). We are setting up the angle_vulkan_memory_allocator_dir but that is just point to the vulkan_memory_allocator directory, which doesn't have a cc file that does the VMA_IMPLEMENTATION trick. We need to make a separate directory that will do that trick then point angle_vulkan_memory_allocator_dir there.
I'm going to reopen this. This fixes the problem described in the description but doesn't make it so you can run opengles playgrounds on linux. I think that should be the outcome of this.
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
gaaclarke commentedon Nov 1, 2024
If you look through the GN files for angle there doesn't seem to be a place where it ever specifies VMA as a dependency. There is some references to what version they'd like to use and there is some references to the fact that Angle uses a fork of VMA in
//doc/BranchingAndRolling.mdHere's some example output I get when trying to link angle on linux:We have the VMA at //third_party/vulkan_memory_allocator. We need to somehow shoehorn that dependency into the angle target.
gaaclarke commentedon Nov 1, 2024
Okay, I think I know what's going on. VMA is kind of a weird library, you have to declare
VMA_IMPLEMENTATIONand include the header in one cc file (https://gpuopen-librariesandsdks.github.io/VulkanMemoryAllocator/html/quick_start.html). We are setting up theangle_vulkan_memory_allocator_dirbut that is just point to the vulkan_memory_allocator directory, which doesn't have a cc file that does the VMA_IMPLEMENTATION trick. We need to make a separate directory that will do that trick then pointangle_vulkan_memory_allocator_dirthere.Made it so angle builds on linux (flutter-team-archive#56328)
gaaclarke commentedon Nov 4, 2024
I'm going to reopen this. This fixes the problem described in the description but doesn't make it so you can run opengles playgrounds on linux. I think that should be the outcome of this.
gaaclarke commentedon Nov 4, 2024
oh, wait, this actually works now, closing it

github-actions commentedon Nov 18, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Made it so angle builds on linux (flutter-team-archive/engine#56328)