Skip to content

[Impeller] adjust size of backdrop filter snapshot in the blur downsample pass #150713

@gaaclarke

Description

@gaaclarke

observed behavior

When performing a backdrop filter blur the coverage hint is ignored when grabbing the input's snapshot. We then only blur a small subset of that snapshot in the blur passes.

Screenshot 2024-06-24 at 11 43 20 AM

Draw area of first blur subpass

For image filters this isn't a problem because the snapshot will be cropped by the hint, this is only for backdrop image filters.

expected behavior

I'd expect the blur passes to only be operating on a texture that is the size required to render the halo correctly. This will make the downsample pass use less compute and less memory. I don't expect it to affect compute used in the blur passes since they are already limited to the area where blur is happening.

cc @jonahwilliams

Metadata

Metadata

Assignees

No one assigned

    Labels

    e: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions