Skip to content

[tool] some tests test for sending GA3 analytics events but not GA4 #150665

New issue
New issue
Closed
Closed
[tool] some tests test for sending GA3 analytics events but not GA4#150665
Assignees
andrewkolos
Labels
P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamtriaged-toolTriaged by Flutter Tool team
@andrewkolos

Description

@andrewkolos
andrewkolos
opened on Jun 23, 2024

Discovered while working on #150575

Example:

flutter/packages/flutter_tools/test/commands.shard/permeable/build_apk_test.dart

Lines 112 to 125 in 2b218fd

testUsingContext('logs success', () async {
final String projectPath = await createProject(tempDir,
arguments: <String>['--no-pub', '--template=app']);
await runBuildApkCommand(projectPath);
expect(testUsage.events, contains(
const TestUsageEvent(
'tool-command-result',
'apk',
label: 'success',
),
));
},

I'm assuming these tests should be making sure we are sending GA4 events as well (using package:unified_analytics).

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-toolOwned by Flutter Tool teamtriaged-toolTriaged by Flutter Tool team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions