Skip to content

SliverLayoutDimensions hash code doesn't include all properties. #150305

@PurplePolyhedron

Description

@PurplePolyhedron

Steps to reproduce

See framework code for SliverLayoutDimensions.hashCode

Expected results

hashCode should include all properties

Actual results

hashCode doesn't include crossAxisExtent, and uses viewportMainAxisExtent twice.

Code sample

the framework code is link

@override
  int get hashCode => Object.hash(
    scrollOffset,
    precedingScrollExtent,
    viewportMainAxisExtent,
    viewportMainAxisExtent
);

Screenshots or Video

No response

Logs

No response

Flutter Doctor output

[✓] Flutter (Channel master, 3.23.0-13.0.pre.242, on macOS 14.4.1 23E224 darwin-arm64, locale en-AU)
    • Flutter version 3.23.0-13.0.pre.242 on channel master at /Users/mainj/fvm/versions/master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5187cab7bd (13 hours ago), 2024-06-14 23:35:34 -0400
    • Engine revision 9779c273aa
    • Dart version 3.5.0 (build 3.5.0-266.0.dev)
    • DevTools version 2.36.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    f: scrollingViewports, list views, slivers, etc.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-frameworkOwned by Framework team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions