Skip to content

[CP] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage #149771

Closed

Description

@jonahwilliams

Issue Link

#148213

Target

stable

PR Link

flutter-team-archive/engine#53235

Changelog Description

  • Fixed rendering error advanced blend is double scaled.

Impacted Users

Impeller on iOS

Impact Description

Rendering appears correct when BlendMode greater than screen is used.

Workaround

Use Skia

Risk

low

Test Coverage

yes

Validation Steps

Run attached tests.

Activity

  1. changed the title [-][CP] <title>[/-] [+][CP] Create framebuffer blend vertices based on the snapshot's texture size instead of coverage[/+] on Jun 5, 2024
  2. zanderso commented on Jul 1, 2024

    @zanderso
    Member

    cp lgtm

  3. itsjustkevin commented on Jul 1, 2024

    @itsjustkevin
    Contributor
  4. github-actions commented on Aug 9, 2024

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

  5. locked as resolved and limited conversation to collaborators on Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

cp: approvedApproved cherry-pick requestcp: mergedCherry-pick has been merged to the release branch.cp: reviewCherry-picks in the review queue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions