-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsplatform-macBuilding on or for macOS specificallyBuilding on or for macOS specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
We're getting ready to upgrade our CI to macOS 14, but Impeller-golden for host_release continuously fails when ran on a Mac-14 staging bot.
Running command "/Volumes/Work/s/w/ir/cache/builder/src/out/ci/mac_release_arm64/dart-sdk/bin/dart --disable-dart-dev bin/golden_tests_harvester.dart /Volumes/Work/s/w/ir/x/t/impeller_goldenb6wwwz8g"
Failed to add image to Skia Gold: Error when running Skia Gold: /Volumes/Work/s/w/ir/cache/gold/goldctl imgtest add --work-dir /Volumes/Work/s/w/ir/x/t/impeller_goldenb6wwwz8g/temp --test-name impeller_Play_AiksTest_CanDrawPerspectiveTransformWithClips_Metal --png-file /Volumes/Work/s/w/ir/x/t/impeller_goldenb6wwwz8g/impeller_Play_AiksTest_CanDrawPerspectiveTransformWithClips_Metal.png --passfail --add-test-optional-key image_matching_algorithm:fuzzy --add-test-optional-key fuzzy_max_different_pixels:7864 --add-test-optional-key fuzzy_pixel_delta_threshold:8
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-engine-gold.skia.org/ to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
stdout: Given image with hash de921969baa2d9717030338ca621acee for test impeller_Play_AiksTest_CanDrawPerspectiveTransformWithClips_Metal
Expectation for test: 34b6d09b8f69f6e98001c212a8505aae (positive)
Expectation for test: 6d37d54bf99c4c61df64497f318622d1 (positive)
Fetching most recent positive digest for trace with ID "ea8697f805ff2d58b9e4c29be6b24923".
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "6d37d54bf99c4c61df64497f318622d1".
Untriaged or negative image: https://flutter-engine-gold.skia.org//detail?grouping=name%3Dimpeller_Play_AiksTest_CanDrawPerspectiveTransformWithClips_Metal%26source_type%3Dflutter-engine&digest=de921969baa2d9717030338ca621acee
stderr: Test: impeller_Play_AiksTest_CanDrawPerspectiveTransformWithClips_Metal FAIL
Unhandled exception:
Failed comparison: impeller_Play_AiksTest_CanDrawPerspectiveTransformWithClips_Metal.png
#0 harvest.<anonymous closure> (package:golden_tests_harvester/golden_tests_harvester.dart:178:7)
#1 _FutureListener.handleError (dart:async/future_impl.dart:181:22)
#2 Future._propagateToListeners.handleError (dart:async/future_impl.dart:873:47)
#3 Future._propagateToListeners (dart:async/future_impl.dart:894:13)
#4 Future._completeError (dart:async/future_impl.dart:674:5)
<asynchronous suspension>
https://ci.chromium.org/b/8746478703122747313
https://ci.chromium.org/b/8746413109650410993
Perhaps the image just needs to be approved? From what I can tell, the difference is undistinguishable
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsImpeller rendering backend issues and features requestsplatform-macBuilding on or for macOS specificallyBuilding on or for macOS specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team