-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
dev/benchmarks/test_apps/stocks includes a demo app called Stocks. It includes generated dart files containing localized messages. These are the *.dart files in the lib/i18n directory.
If you run flutter gen-l10n (which is ran automatically during flutter pub get), you'll notice these files will be updated. However, these updated files will fail lint checks1 (see #149342 (comment)). This stops us from committing re-generated files into the repo.
For me personally, this issue annoying because—in my local setup—flutter pub get is run on every package when I switch branches while working on flutter/flutter. This will regenerate these files, cluttering the staging area of my local checkout.
I propose we do one of the following:
- Disable lints entirely for these files by adding a
// ignore_for_file: type=lintinto these templates. - Update the templates to not fail these lint checks (which may not be straightforward—see update generated localized message files in the stocks test app #148741 (comment)).
Once we do either of these, we can check in the updated files. The first option may be better since its simpler and avoids this type of issue in the future, which would be nice for contributors and users alike (see #106150).
Footnotes
-
noop_primitive_operationsanduse_super_parameters, in particular ↩