Skip to content

et used to auto-generate missing gn builds if omitted, regressed in #52832 #148442

@matanlurey

Description

@matanlurey

In flutter/engine#52832, I unintentionally removed the generation of missing gn confgs.

Specifically, this code used to run:

final List<BuildTarget>? selectedTargets = await targetsFromCommandLine(...);
...
// If the expected build output directory doesn't exist yet, eagerly run
// the build's GN step to try to produce it.
if (!buildDir.existsSync()) {

Notably, this still would not have addressed #148431, because the above code only handled missing directories. I'm not sure how we can detect (or if we should) broken directories, so I'll file a separate issue for discussion.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: regressionIt was better in the past than it is nowc: tech-debtTechnical debt, code quality, testing, etc.e: engine-toolEngine-specific tooling (i.e. `tools/engine_tool`).team-engineOwned by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions