Proposal: use "enhanced enums" in the repo for reduced boilerplate

There are a few situations where the same enum logic is implemented over and over again.

<br>

A good example would be distinguishing an `AnimationStatus` between forward/complete and reverse/dismissed.

<details open> <summary>15 <a href="https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or-or-with-enum-values">style guide violations</a> (click to collapse)</summary>

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/flutter_gallery/lib/demo/material/backdrop_demo.dart#L281

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/flutter_gallery/lib/demo/shrine/backdrop.dart#L235

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/flutter_gallery/lib/demo/shrine/expanding_bottom_sheet.dart#L236

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/flutter_gallery/lib/gallery/backdrop.dart#L260

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/new_gallery/lib/pages/splash.dart#L71-L72

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/new_gallery/lib/studies/reply/adaptive_nav.dart#L525-L526

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/new_gallery/lib/studies/shrine/app.dart#L122-L123

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/new_gallery/lib/studies/shrine/backdrop.dart#L214-L215

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/dev/integration_tests/new_gallery/lib/studies/shrine/expanding_bottom_sheet.dart#L343-L344

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/packages/flutter/lib/src/material/navigation_bar.dart#L1309-L1310

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/packages/flutter/lib/src/material/navigation_drawer.dart#L691

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/packages/flutter/lib/src/material/scaffold.dart#L610-L611

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/packages/flutter/lib/src/material/scaffold.dart#L3206-L3207

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/packages/flutter/lib/src/widgets/animated_cross_fade.dart#L320-L321

https://github.com/flutter/flutter/blob/31847bcc4424921e3e5d58901a2573fa8a502758/packages/flutter/lib/src/widgets/routes.dart#L1939-L1940

</details>

Rather than refactoring all of these into switch expressions, I think it'd be best to take advantage of [enhanced enum](https://dart.dev/language/enums#declaring-enhanced-enums) features and improve `AnimationStatus` directly.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Proposal: use "enhanced enums" in the repo for reduced boilerplate #147799

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return _controller.status == AnimationStatus.completed \|\|
	_controller.status == AnimationStatus.forward;

	return status == AnimationStatus.completed \|\|
	status == AnimationStatus.forward;

	if (status == AnimationStatus.completed \|\|
	status == AnimationStatus.forward) {

	return animation.status == AnimationStatus.forward
	\|\| animation.status == AnimationStatus.completed;

	_snackBarController!.status == AnimationStatus.forward \|\|
	_snackBarController!.status == AnimationStatus.completed,

	widget.animationController.status == AnimationStatus.forward
	\|\| widget.animationController.status == AnimationStatus.completed,

	final bool transitioningForwards = _controller.status == AnimationStatus.completed \|\|
	_controller.status == AnimationStatus.forward;

	ignoring: animation!.status == AnimationStatus.reverse \|\| // changedInternalState is called when animation.status updates
	animation!.status == AnimationStatus.dismissed, // dismissed is possible when doing a manual pop gesture

Proposal: use "enhanced enums" in the repo for reduced boilerplate #147799

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions