Skip to content

ObjcOptions.headerIncludePath not used #147587

@vashworth

Description

@vashworth

What package does this bug report belong to?

pigeon

What target platforms are you seeing this bug on?

iOS

Have you already upgraded your packages?

Yes

Dependency versions

pubspec.lock
[Paste file content here]

Steps to reproduce

  1. Edit objcOptions in packages/image_picker/image_picker_ios/pigeons/messages.dart and add headerIncludePath
@ConfigurePigeon(PigeonOptions(
  ...
  objcOptions: ObjcOptions(
    prefix: 'FLT',
    headerIncludePath: 'image_picker_ios/messages.g.h'
  ),
  ...
))
  1. cd path/to/packages/packages/image_picker/image_picker_ios
  2. Run dart run pigeon --input pigeons/messages.dart

Expected results

I would expect messages.g.m to have

#import "image_picker_ios/messages.g.h"

Actual results

Instead, messages.g.m has

#import "messages.g.h"

Code sample

Use https://github.com/flutter/packages/blob/ebd138dc43e6f306e08662f42f92d97fc9caff68/packages/image_picker/image_picker_ios/pigeons/messages.dart as code sample

Screenshots or Videos

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel master, 3.22.0-16.0.pre.44, on macOS 14.4.1 23E224 darwin-arm64, locale en)
    ! Upstream repository xxxx is not a standard remote.
[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 15.0)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.1)
[✓] VS Code (version 1.88.1)
[✓] Connected device (5 available)
[✓] Network resources

! Doctor found issues in 2 categories.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listp: pigeonrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.platform-iosiOS applications specificallyteam-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions