-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-fuchsiaFuchsia code specificallyFuchsia code specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Steps to reproduce
Fuchsia's fake-display will migrate to sysmem2 soon, at which point usages of fake-display (such as in flutter tests) will need to route fuchsia.sysmem2.Allocator.
Expected results
If fuchsia.sysmem2.Allocator is routed, the protocol routing error will be avoided and tests will pass (even with fake-display using fuchsia.sysmem2.Allocator).
Actual results
Fuchsia would log a protocol routing error indicating that fuchsia.sysmem2.Allocator wasn't made available, and some tests would fail. The error would look like this:
[display-coordinator-connector] WARN: Required protocol `fuchsia.sysmem2.Allocator` was not available for target component [...]
Code sample
See the PR for tests that will fail if we don't route fuchsia.sysmem2.Allocator in those tests.
Screenshots or Video
NA
Logs
NA
Flutter Doctor output
NA
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-fuchsiaFuchsia code specificallyFuchsia code specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team