-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#6404Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listp: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform team
Description
The recent update of the GoogleSignIn iOS SDK to v7.1.0 seems to have broken our CI in 2 ways:
- Mac_x64 check_podspecs - Build failure.
- Mac_arm64 ios_platform_tests_shard_1 master - Build failure.
As a mitigation, the version of the SDK has been pinned to 7.0.0, here:
But the pin needs to be cleaned up.
Earlier description
The "Mac_x64 check_podspecs" seems to be consistently failing in flutter/packages; there's a warning while checking google_sign_in_os:
- WARN | swift: The validator used Swift `4.0` by default because no Swift
version was specified. To specify a Swift version during validation, add the
`swift_versions` attribute in your podspec. Note that usage of a `.swift-version`
file is now deprecated.
In the meantime, Reverted, as the change exposed another issue, mentioned below!--allow-warnings has been added to podspec_check_command.dart to unblock the tree. (Please, revert flutter/packages#6416 as part of this fix!)
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listp: google_sign_inThe Google Sign-In pluginThe Google Sign-In pluginpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform team