Skip to content

[flutter release] strategy on better ways to merge cherry pick PR #145557

@XilaiZhang

Description

@XilaiZhang

For the longest time I thought cherry pick author should be the one tuning the tests and merging the PR, but today I read https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process and realized that it says "The release engineering team will merge the cherry-pick pull request"

In this week's release #145184 and flutter/engine#51425 were merged by me, and I had to rerun tests and stamp LGTM on one of them. However, I didn't realize #145181 was also left open as a cherry pick PR and not merged.

Would it be possible to change the policy, so that PR authors are the one merging cherry pick PRs?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions