-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Description
Goma will be turned down Real Soon Now, and local dev workflows for RBE require the compiler proxy to be started and stopped around each ninja invocation. et knows how to do that in the context of executing engine_v2 build configs, and can provide a smooth migration pathway from Goma to RBE. A difficulty is that the engine_v2 build configs were not designed with local dev workflows in mind, and so do not neatly fill the need being served by direct invocation of tools/gn + ninja.
Some local dev builds have been described in ci/builders/local_engine.json, but these are not yet running in CI, and the names of the builds in that file duplicate some of the pre-existing CI build names.
While not fulling solving #145185, I am going to alleviate the difficulties above with the main goal being to mitigate the disruption due to Goma's turn down. My plan is the following:
- Change the name of builds outside of
local_engine.jsonby prefixing them withci/, and add a test to ensure that remains consistent. - With the goal of running each of the
local_engine.jsonbuilds in CI on each platform, I will make by-hand internal copies of each config. The name of each config will be prefixed by the name of the platform it will run on, e.g.macos/host_debugto avoid name conflicts with theci/builds. I'll add a test for this to ensure it remains consistent. (Eventuallylocal_engine.jsonshould be machine generated, but that's not a requirement for the Goma -> RBE transition, so we should put that off until later.) - With the goal that
et build -c host_debugetc. will continue to work on all dev platforms. I will teachetthat a config name passed toet buildandet runthat does not have aci/prefix should have the os name prefixed to it so that it can be found inlocal_engine.json. - I will add human-readable descriptions to all builds, and teach
etabout those fields to report them in help messages, etc.
That last one is optional, but I think I'll need it for my own sanity.