Skip to content

Use singular static const for minimum iOS/macOS version where possible #145104

Open

Description

@vashworth

The minimum iOS/macOS deployment version is hardcoded in a bunch of different places within the tool. It would be nice if we had a single const we can use everywhere.

Would also be nice if we could make it a variable in the templates so we don't have to change each template manually.

Here's some examples of places it's used:

https://github.com/flutter/flutter/pull/140823/files

Activity

  1. added
    platform-iosiOS applications specifically
    toolAffects the "flutter" command-line tool. See also t: labels.
    team-iosOwned by iOS platform team
    fyi-toolFor the attention of Flutter Tool team
    P2Important issues not at the top of the work list
    c: tech-debtTechnical debt, code quality, testing, etc.
    on Mar 13, 2024
  2. jmagman commented on Mar 13, 2024

    @jmagman
    Member

    +1 for doing this in the tool and templates. The dev and example changes are annoying and add lots of files, but I usually use them as proof that the version migrator is doing what I expect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.platform-iosiOS applications specificallyteam-iosOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform team

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions