-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-webOwned by Web platform teamOwned by Web platform team
Description
Type of Request
bug
Infrastructure Environment
felt tests (flutter/engine tests on the web platform)
What is happening?
It seems that some felt test suites are not re-generating the flutter_js asset as needed. This makes them order-dependent with other bits of the testing infrastructure of the repo (and seemingly random when validating locally). For example:
test/fallbacks/fallbacks_test.dart
Steps to reproduce
On a flutter/engine checkout:
- Remove
src/out/web_teststo remove all the test-related stuff - Attempt to run the test above:
felt test test/fallbacks/fallbacks_test.dart- The test will time-out after 12 minutes.
- ... Alternatively, for more output:
felt test --debug --start-paused test/fallbacks/fallbacks_test.dart- Look at the network panel, and you'll see that the
fluter_js/flutter.jsis a 404 error.
- Look at the network panel, and you'll see that the
- Also check how:
src/out/web_tests/artifacts/flutter_jsdoesn't exist.
To recover from this, you may run other suite:
- Run:
felt test test/engine/canvas_test.dart - Check
src/out/web_tests/artifacts/flutter_jsnow.
Expected results
I'd expect to be able to run test/fallbacks/fallbacks_test.dart without needing side effects from other tests existing first.
Metadata
Metadata
Assignees
Labels
c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-webOwned by Web platform teamOwned by Web platform team