Skip to content

golden_tests_harvester should panic if !SkiaGoldClient.isAvailable #144948

@matanlurey

Description

@matanlurey

See flutter/engine#51325.

Before flutter/engine#50844, when golden_tests_harvester was invoked in a release builder (i.e. where isLuci evaluates to true, but SkiaGoldClient.isAvailable evaluates to false), it would just ... party on, seemingly producing no errors. I'm not sure exactly how.

Personally, I don't think a tool should "pretend" to run as a silent behavior, that is, if it's invoked, it should run.

Ideas:

  1. Embrace Conditionally run golden_tests_harvester for run_impeller_golden_tests. engine#51325, and panic if executed without GOLDCTL. Probably tear-out the FakeSkiaGoldClient stuff.
  2. Add a flag (--dry-run or similar) that makes this explicit versus implicit. Even --dry-run-if-gold-ctl-omitted is better.
  3. Embrace chaos and close this PR as WAI.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.team-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions