-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#51364Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
See flutter/engine#51325.
Before flutter/engine#50844, when golden_tests_harvester was invoked in a release builder (i.e. where isLuci evaluates to true, but SkiaGoldClient.isAvailable evaluates to false), it would just ... party on, seemingly producing no errors. I'm not sure exactly how.
Personally, I don't think a tool should "pretend" to run as a silent behavior, that is, if it's invoked, it should run.
Ideas:
- Embrace Conditionally run
golden_tests_harvesterforrun_impeller_golden_tests. engine#51325, and panic if executed withoutGOLDCTL. Probably tear-out theFakeSkiaGoldClientstuff. - Add a flag (
--dry-runor similar) that makes this explicit versus implicit. Even--dry-run-if-gold-ctl-omittedis better. - Embrace chaos and close this PR as WAI.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team