-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#51265Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team
Description
Files under the build_overrides directory in the buildroot are typically hardcoded imports in third-party dependencies used for project-specific configuration. For example, ANGLE hardcodes an import of //build_overrides/angle.gni so that consumers of ANGLE can configure the build to their needs.
We can add a copy all existing src/build_overrides files at the equivalent src/flutter/build_overrides path in the engine. A followup patch will replace each existing file under src/build_overrides in the buildroot with a shim that just imports the files landed in this patch. This allows the upstream project to continue hardcoding the //build_overrides/foo.gni path, but provides a seamless path forward
when we drop the buildroot.
Part of #67373.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team