-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#55262Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.flutter-gpur: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Milestone
Description
So far, we have:
- Impeller "Dart renderer unittests": renderer_dart_unittests.cc + dart_tests.dart
- Runs in CI.
- Been using this primarily to cover the API in a crash smoke test.
- Can't actually draw anything visual to the playgrounds.
- flutter_tester: gpu_test.dart
- Runs in CI.
- Up until now, I've only used this to test what happens when someone tries to use Flutter GPU even though Impeller isn't available. Now that flutter_tester supports Impeller, this is potentially a good way to perform behavioral testing and perhaps submit goldens.
We should clean up this testing situation and establish a clear pattern. My immediate suggestion would be:
- See if we can do all behavioral testing/golden collection using
flutter_testerat this point. - Stretch goal: Make the "Dart renderer unittests" actually display to Impeller's playground. This would be a convenient/useful debugging tool.
lin72h and wanjm
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.flutter-gpur: fixedIssue is closed as already fixed in a newer versionIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Type
Projects
Status
✅ Done