Skip to content

[Flutter GPU] Establish a better unittesting scheme to cover API behavior changes. #144640

@bdero

Description

@bdero

So far, we have:

  • Impeller "Dart renderer unittests": renderer_dart_unittests.cc + dart_tests.dart
    • Runs in CI.
    • Been using this primarily to cover the API in a crash smoke test.
    • Can't actually draw anything visual to the playgrounds.
  • flutter_tester: gpu_test.dart
    • Runs in CI.
    • Up until now, I've only used this to test what happens when someone tries to use Flutter GPU even though Impeller isn't available. Now that flutter_tester supports Impeller, this is potentially a good way to perform behavioral testing and perhaps submit goldens.

We should clean up this testing situation and establish a clear pattern. My immediate suggestion would be:

  1. See if we can do all behavioral testing/golden collection using flutter_tester at this point.
  2. Stretch goal: Make the "Dart renderer unittests" actually display to Impeller's playground. This would be a convenient/useful debugging tool.

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.flutter-gpur: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

Status

✅ Done

Relationships

None yet

Development

No branches or pull requests

Issue actions