Skip to content

ImageReaderSurfaceProducer renders incorrectly #144199

@matanlurey

Description

@matanlurey

Caught by flutter/engine#50993, which I am reverting.

I think this code is intended to be virtually unused, though if an end-user tried it (it's available in stable) it would render incorrectly. Marking as a P1 because this will block @dnfield's work to enable Impeller on scenario_app (since we need ImageReaderSurfaceProducer).

See https://flutter-engine-gold.skia.org/search?crs=github&issue=50993&negative=true&patchsets=2&untriaged=false.

ExternalTextureTests_testRotatedMediaSurface_180

Not rotated as expected

image

Similar for:

  • ExternalTextureTests_testRotatedMediaSurface_270
  • ExternalTextureTests_testRotatedMediaSurface_90
  • ExternalTextureTests_testCroppedRotatedMediaSurface_bottomLeft_90
  • ExternalTextureTests_testCroppedMediaSurface_topRight
  • ExternalTextureTests_testCroppedRotatedMediaSurface_bottomLeft_90
  • ExternalTextureTests_testCroppedMediaSurface_bottomLeft

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work liste: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.fyi-androidFor the attention of Android platform teamplatform-androidAndroid applications specificallyteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions