-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#51751Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: scenario-appThe `testing/scenario_app` fixture in the engineThe `testing/scenario_app` fixture in the engineengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.fyi-androidFor the attention of Android platform teamFor the attention of Android platform teamteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
As a result of flutter/engine#50826, the engine now reports failures on untriaged Skia gold images.
However, something unintended happened - builds marked bringup: true are now infinitely failing:
We need to resolve this, having bringup builds that never pass are not useful.
test: Android Scenario App Integration Tests (Impeller/OpenGLES)
skia gold comparison failed: Exception: Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-engine-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
Debug information for Gold --------------------------------
stdout: Given image with hash 2259df20880399e76dbb98daebc5dca0 for test ExternalTextureTests_testCroppedRotatedMediaSurface_bottomLeft_90
Expectation for test: 2259df20880399e76dbb98daebc5dca0 (positive)
Expectation for test: 2f80cb176bc70e3f26da67f98cb81bb0 (positive)
Expectation for test: 5ea0bffc5ccbe4c3a97abf8959412ac0 (positive)
Expectation for test: 68a643f1d6ccbd866706a08947350551 (positive)
Expectation for test: b2454b91473a21dd73f67c7da0336a44 (positive)
Expectation for test: a7ddd05be8c2585d87512b742037e17d (negative)
Expectation for test: d04cb0034d0bbce86b1cf2c21d7e2470 (positive)
Expectation for test: 0f71af5ad275f8c20ea58f055dcd878c (positive)
Expectation for test: 1cd13164b4fb06892df47c5978419ef9 (positive)
Expectation for test: 5a0525040ca8d8539011bb80c95a0741 (positive)
Expectation for test: 5ba6df7acef516f7dab78587cf30ce20 (positive)
Expectation for test: 84d38d076525be7a707bb040536f8089 (positive)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730741929048499.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
stderr: Error running commandtest: Scenario App Integration Tests (API 33)
skia gold comparison failed: Exception: Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/engine are triaged
in pre-submit during code review for the given PR.
Visit https://flutter-engine-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
Debug information for Gold --------------------------------
stdout: Given image with hash 38d4029cea965bcc54e3ad97d07bb324 for test DrawSolidBlueScreenTest
Expectation for test: 0ecdc939286da111fcf82bc55f2c025c (positive)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Fetching most recent positive digest for trace with ID "32fd77fb672873775ff1b28d8de3429b".
No recent positive digests for trace with ID "32fd77fb672873775ff1b28d8de3429b". This probably means that the test was newly added.
Non-exact image comparison using algorithm "fuzzy" against most recent positive digest "".
Untriaged or negative image: https://flutter-engine-gold.skia.org/detail?grouping=name%3DDrawSolidBlueScreenTest%26source_type%3Dflutter-engine&digest=38d4029cea965bcc54e3ad97d07bb324
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
Error closing file skia-gold-flutter-engine/dm-json-v1/2024/02/23/23/ca2452074a49938ffb04b9614aed480a04fef1c6/waterfall/dm-1708730981516094698.json: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden (retrying)
stderr: Error running command: ''Error uploading image /b/s/w/ir/x/w/recipe_cleanup/flutter_logs_dir/DrawSolidBlueScreenTest.png to gs://skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png. Got: uploading 10480 bytes to skia-gold-flutter-engine/dm-images-v1/38d4029cea965bcc54e3ad97d07bb324.png with exponential retries: googleapi: Error 403: flutter-staging-builder@chops-service-accounts.iam.gserviceaccount.com does not have storage.objects.create access to the Google Cloud Storage object. Permission 'storage.objects.create' denied on resource (or it may not exist)., forbidden. At gcsuploader.go:180 retry.go:37 retry.go:24 gcsuploader.go:154 gcsuploader.go:130 goldclient.go:340 errgroup.go:75 asm_amd64.s:1650. At goldclient.go:341 errgroup.go:75 asm_amd64.s:1650''Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.e: scenario-appThe `testing/scenario_app` fixture in the engineThe `testing/scenario_app` fixture in the engineengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.fyi-androidFor the attention of Android platform teamFor the attention of Android platform teamteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team