-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#50875Closed
Copy link
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team
Description
See #143782, #143782 (comment).
As-per chatting with @zanderso let's do the following:
- Pull out the clause from
lint.shtoban_generated_plugin_registrant_java.sh - Create a new invocation of the script on
linux_unopt
In addition, we should make the following improvements (/cc @dnfield):
- Only look for files in
src/flutter(i.e. it should not look insrc/third_party) - Additionally ignore
src/flutter/third_partyfor the same reason (eventually they will be the same)
I considered moving this to a Dart script, but I'm concerned about the performance cost of using a deep recursive file search versus just shelling out to find, and because this mostly breaks local development it's nice to get actionable feedback from the git hooks instead of waiting purely for CI failures.
dnfield
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team