Skip to content

[Flutter GPU] Standardize a message error pattern. #143891

@bdero

Description

@bdero

Part of #130921

Right now, we have a mix of error handling that may be confusing to users.

  • Sometimes a success boolean is returned.
  • Sometimes an exception is thrown if there's a problem.
  • Sometimes Impeller validation will catch problems and rendering will fail.
  • Sometimes the Impeller backend will allow something invalid to happen and rendering will silently fail unless the user has Metal or Vulkan validations enabled.

Recommendation: Bias heavily towards exception throwing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: proposalA detailed proposal for a change to Flutterengineflutter/engine related. See also e: labels.flutter-gpur: fixedIssue is closed as already fixed in a newer versionteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions