Skip to content

hourMinuteTextStyle Material 3 default doesn't match the specs #143748

New issue
New issue
Closed
#143749
Closed
hourMinuteTextStyle Material 3 default doesn't match the specs#143748
#143749
Assignees
TahaTesser
Labels
c: proposalA detailed proposal for a change to Flutterf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages team
@TahaTesser

Description

@TahaTesser
TahaTesser
opened on Feb 20, 2024

Use case

hourMinuteTextStyle should be using a different font styles for the dial and input mode according to Material 3 specs. Currently uses it uses only one text style for both entry modes.

Expected Values

Screenshot 2024-02-20 at 15 06 40

Screenshot 2024-02-20 at 15 07 22

Actual Value

flutter/packages/flutter/lib/src/material/time_picker.dart

Lines 3609 to 3617 in 1a7a061

@override
TextStyle get hourMinuteTextStyle {
return MaterialStateTextStyle.resolveWith((Set<MaterialState> states) {
// TODO(tahatesser): Update this when https://github.com/flutter/flutter/issues/131247 is fixed.
// This is using the correct text style from Material 3 spec.
// https://m3.material.io/components/time-pickers/specs#fd0b6939-edab-4058-82e1-93d163945215
return _textTheme.displayMedium!.copyWith(color: _hourMinuteTextColor.resolve(states));
});
}

Proposal

Update hourMinuteTextStyle defaults to match Material 3 specs.

Metadata

Metadata

Assignees

Labels

c: proposalA detailed proposal for a change to Flutterf: material designflutter/packages/flutter/material repository.frameworkflutter/packages/flutter repository. See also f: labels.r: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages team

Type

No type

Projects

Nevercode

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions