-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecte: scenario-appThe `testing/scenario_app` fixture in the engineThe `testing/scenario_app` fixture in the engineplatform-androidAndroid applications specificallyAndroid applications specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
🚫 Blocking #143471.
In flutter/engine#50722, which should have no effect on goldens, I get a (flaky) diff:
Let me 🔍 in:
| Location | Left Pixel | Right Pixel |
|---|---|---|
| 0x0 | #373737 |
#000000 |
| 1x0 | #090909 |
#000000 |
In other words, sometimes the screen is entirely pure black (#000000), and sometimes the top has a dark grey 1-pixel border that is #373737, with the remaining screen being almost black (#090909). I don't see any of those colors referenced directly in the app.
Some other thoughts:
- Flutter is not full screen (per @jonahwilliams it would be "clear to transparent black")
- It's likely the non "pure-black" screen is some sort of inherited "Dark Mode" color scheme
- We are not explicitly setting the theme anywhere, maybe some CI configurations are different?
For onlookers, the app is here: https://github.com/flutter/engine/tree/main/testing/scenario_app/android.
/cc @reidbaker @johnmccutchan if anything stands out to you.
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecte: scenario-appThe `testing/scenario_app` fixture in the engineThe `testing/scenario_app` fixture in the engineplatform-androidAndroid applications specificallyAndroid applications specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team

