-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/engine
#50937Closed
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work liste: scenario-appThe `testing/scenario_app` fixture in the engineThe `testing/scenario_app` fixture in the engineplatform-androidAndroid applications specificallyAndroid applications specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Currently the (Android) scenario_app has very rudimentary logging, including dumping the full adb logcat to stdout:
- Starting
adb logcatin the Dart process. - On
trap ... EXIT, dumps the logs to stdout.
Ideally, we'd filter and only show messages relevant to the running app (or test suite). Must haves:
- Messages printed from the Java or Dart applications or test suite
- Uncaught exceptions or asserts from the Java or Dart applications or test suite
- Verification that screenshots have been taken and uploaded to Skia gold (if applicable)
- More status logging (see Impeller OpenGLES (Scenario App) Tests are unstable on CI #143626)
This work is somewhat important, because debugging these tests on CI (and even locally) is non-trivial, and we suspect cases where certain tests are not running, or not taking screenshots consistently (at least on CI). Logging would be one part of feeling more certain that the tests are running as expected.
Log filtering historically has been brittle, so it might be good to have some small tests that verify this keeps working.
Tip
The Flutter tool does something like this, so maybe pick @christopherfujino or @jonahwilliams 🧠 .
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work liste: scenario-appThe `testing/scenario_app` fixture in the engineThe `testing/scenario_app` fixture in the engineplatform-androidAndroid applications specificallyAndroid applications specificallyteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team