-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/cocoon
#3487Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listblockedIssue is blocked by another issueIssue is blocked by another issuec: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.fyi-androidFor the attention of Android platform teamFor the attention of Android platform teamfyi-iosFor the attention of iOS platform teamFor the attention of iOS platform teamfyi-webFor the attention of Web platform teamFor the attention of Web platform teamteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
Description
Currently, the gold integration in flutter/engine is different than flutter/flutter:
- We allow PRs to land that create untriaged goldens, and some do so regularly (i.e. the Skia roller)
- Untriaged goldens do not turn the tree red
According to @zanderso, this is mostly due to historics and technical debt. My wording below:
- There isn't a good way to notify gardeners that a PR has stalled. Some work was done, but the email the gardener receive is not the best and is unlikely to improve in the short-term.
- A stalled roller would often stall for hours or days at a time, frustrating/slowing down upstream teams.
As a result, at the time of this writing, we have almost 200 untriaged digests (up about 10 from this AM):
This has the following side-effects:
- When Skia Gold doesn't filter based on PR as expected (happens often), 100s of untriaged digests show up instead of the (less than 100s) expected.
- It's possible to regress due to out-of-stream updates (i.e. updates to Skia, Vulkan Deps, SwiftShader, etc) that aren't caught.
This issue is a proposal to change that. We would:
- Triage all untriaged goldens
- Block rollers that have untriaged goldens, expecting the engine gardener to intervene
- Turn the tree red if 1+ untriaged goldens exist, as we should never have any (similar to framework)
We believe this will most impact the gardener, and the web team (under @yjbanov).
zanderso and johnmccutchan
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listblockedIssue is blocked by another issueIssue is blocked by another issuec: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.fyi-androidFor the attention of Android platform teamFor the attention of Android platform teamfyi-iosFor the attention of iOS platform teamFor the attention of iOS platform teamfyi-webFor the attention of Web platform teamFor the attention of Web platform teamteam-engineOwned by Engine teamOwned by Engine teamtriaged-engineTriaged by Engine teamTriaged by Engine team
