-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine team
Description
At API Version 29+, we use ImageReader instead of SurfaceTexture.
However, many devices will continue to use the older SurfaceTexture-based APIs for a long time, and we've historically broken external texture support here.
My suggestion is to:
- Add a Skia variant with API version 28 to
ci/builders/linux_android_emulator.json - Do the same thing for Impeller + OpenGLES
- Migrate the "plugins" in
scenario_app/android/*(example) to theSurfaceProducerpattern
With these steps, we'll be running:
- Skia + OpenGLES (Implicit) + ImageReader
- Skia + OpenGLES (Implicit) + SurfaceTexture
- Impeller + OpenGLES (Explicit) + ImageReader
- Impeller + OpenGLES (Explicit) + SurfaceTexture
- Impeller + Vulkan (Explicit) + ImageReader
/cc @johnmccutchan @gaaclarke @jonahwilliams for FYI, I'll be sending a PR but chime in if you disagree.
johnmccutchan
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: proposalA detailed proposal for a change to FlutterA detailed proposal for a change to Flutterc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.team-engineOwned by Engine teamOwned by Engine team