Skip to content

Typos in flutter_test/lib/src/controller.dart #143173

@saintmac-google

Description

@saintmac-google

Steps to reproduce

The function [simulatedAccessibilityTraversal] has deprecated the use of [start] and [end] in favor of [startNode] and [endNode], however, the latter parameters are not used to calculate the start and end index for the iteration:

This is forcing me to use the deprecated [start]/[end] parameters to filter the result.

other minor typos:

'The end node is not part of the provided view.\n'

it should say "The start node... View of start node...", it says "The end node... View of end node..."

Expected results

There should be in the code something like:

if (startNode != null) {
  startIndex = ...
}
if (endNode != null) {
  endIndex = ...
}

Actual results

it only contains

if (start != null) ...

Code sample

Code sample
n/a

Screenshots or Video

Screenshots / Video demonstration

[Upload media here]

Logs

Logs
[Paste your logs here]

Flutter Doctor output

Doctor output
n/a

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsc: tech-debtTechnical debt, code quality, testing, etc.frameworkflutter/packages/flutter repository. See also f: labels.team-frameworkOwned by Framework teamtriaged-frameworkTriaged by Framework teamwaiting for PR to land (fixed)A fix is in flight

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions