Skip to content

[web] Flutter test suite in the web needs love. #143124

@ditman

Description

@ditman

While investigating this revert, a couple of concerning things were discovered wrt the Flutter test suite in the web.

  1. The revert was caused because some tests failed when the scene of the HTML renderer started respecting the "overridden" value of devicePixelRatio to report its "logical size".

  2. The devicePixelRatio overridden by flutter tests (3.0) does NOT match the devicePixelRatio set by the browser when it starts.

    • In fact, the browser is starting always with DPR=1. It should pass '--force-device-scale-factor=X' for other DPRs.
  3. By hijacking the _matchers_web.dart file, it seems that the isCanvasKit boolean used there to determine how to match a golden never returns true (this might be a regression) Fixed by: Pass along web renderer into debugging options in the test command. #143128


TL;DR: The flutter test runner needs some love in the flutter/flutter repository.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our testsplatform-webWeb applications specificallyteam-webOwned by Web platform teamtoolAffects the "flutter" command-line tool. See also t: labels.triaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions