Skip to content

[Impeller] perform golden texture flip on the GPU #142641

@gaaclarke

Description

@gaaclarke

In flutter/engine#50146 OpenGLES goldens were introduced, but the OpenGLES renderer holds textures with the Y flipped. In order to account for this we flip the textures upside down on the CPU before writing the png files. In theory that flipping should be able to be performed by the blit pass for better performance.

In Vulkans case the destination rect for the blit can have negative y coordinates, which should flip the texture.

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Issues that are less important to the Flutter projecte: impellerImpeller rendering backend issues and features requeststeam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions