[Impeller] Play/AiksTest.EmptySaveLayerRendersWithClear/Vulkan has validation warnings #142080
Description
blocking #142017
reproduction
Apply the following patch
--- a/impeller/golden_tests/golden_playground_test_mac.cc
+++ b/impeller/golden_tests/golden_playground_test_mac.cc
@@ -113,13 +113,14 @@ bool SaveScreenshot(std::unique_ptr<testing::Screenshot> screenshot) {
}
bool ShouldTestHaveVulkanValidations() {
- bool enable_vulkan_validations = false;
- std::string test_name = GetTestName();
- if (std::find(kVulkanValidationTests.begin(), kVulkanValidationTests.end(),
- test_name) != kVulkanValidationTests.end()) {
- enable_vulkan_validations = true;
- }
- return enable_vulkan_validations;
+ return true;
+ // bool enable_vulkan_validations = false;
+ // std::string test_name = GetTestName();
+ // if (std::find(kVulkanValidationTests.begin(), kVulkanValidationTests.end(),
+ // test_name) != kVulkanValidationTests.end()) {
+ // enable_vulkan_validations = true;
+ // }
+ // return enable_vulkan_validations;
}
} // namespaceThen execute impeller_golden_tests --working_dir=<PATH> --gtest_filter="*EmptySaveLayerRendersWithClear*Vulkan.
error
--- Vulkan Debug Report ----------------------------------------
| Severity: Error
| Type: { Validation }
| ID Name: UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout
| ID Number: 1303270965
| Queue Breadcrumbs: [NONE]
| CMD Buffer Breadcrumbs: Texture Fill: Subpass, Intersect Clip, Texture Fill, QueueSubmit
| Related Objects: CommandBuffer [5321108352] [EntityPass Command Buffer: Depth=0 Count=0]
| Trigger: Validation Error: [ UNASSIGNED-CoreValidation-DrawState-InvalidImageLayout ] Object 0: handle = 0x13d29ab80, name = EntityPass Command Buffer: Depth=0 Count=0, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0x4dae5635 | vkQueueSubmit(): pSubmits[0].pCommandBuffers[0] command buffer VkCommandBuffer 0x13d29ab80[EntityPass Command Buffer: Depth=0 Count=0] expects VkImage 0x4479900000000181[EntityPass Color Texture] (subresource: aspectMask 0x1 array layer 0, mip level 0) to be in layout VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL--instead, current layout is VK_IMAGE_LAYOUT_UNDEFINED.
-----------------------------------------------------------------