TapGestureRecognizer leaked by _RenderSlider and _RenderRangeSlider #14204

Activity

1. Hixie

   changed the title [-]TapGestureRecognizer is not disposed in framework[/-] [+]TapGestureRecognizer leaked by RenderToggleable, _RenderCupertinoSwitch, _RenderSlider[/+] on Jan 22, 2018
2. Hixie

   added

   c: crashStack traces logged to the consoleStack traces logged to the console

   frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.

   on Jan 22, 2018
3. Hixie

   added this to the 4: Next milestoneThis milestone has been deleted milestone on Jan 22, 2018
4. Hixie commented on Jan 22, 2018

   

   Hixie

   on Jan 22, 2018

   Contributor

   More actions

   Sounds like a bug.
5. cbracken commented on Sep 19, 2018

   

   cbracken

   on Sep 19, 2018

   Member

   More actions

   /cc @xster @HansMuller
6. tvolkert commented on Jan 13, 2020

   

   tvolkert

   on Jan 13, 2020

   Contributor

   More actions

   @goderbauer
7. goderbauer commented on Jan 13, 2020

   

   goderbauer

   on Jan 13, 2020

   Member

   More actions

   Problem is still present, we should fix it by creating the Recognizers on attach and disposing them on detach, similarly to how we fixed this for RenderEditable in #42076.
8. goderbauer

   added

   easy fix

   on Jan 13, 2020
9. goderbauer

   self-assigned this

   on Jan 13, 2020
10. goderbauer

    added

    easy fix

    and removed

    easy fix

    on Jan 24, 2020
11. goderbauer

    removed their assignment

    on Jan 24, 2020
12. goderbauer commented on Feb 24, 2020

    

    goderbauer

    on Feb 24, 2020

    Member

    More actions

    Instead of what I am suggestion above, we should do what's suggested in #49999 (comment) to address this problem.
13. kf6gpe

    added

    P2Important issues not at the top of the work listImportant issues not at the top of the work list

    on May 29, 2020
14. 1 remaining item

    Load more
15. pedromassangocode

    added

    found in release: 1.21Found to occur in 1.21Found to occur in 1.21

    has reproducible stepsThe issue has been confirmed reproducible and is ready to work onThe issue has been confirmed reproducible and is ready to work on

    and removed

    easy fix

    on Jul 23, 2020
16. Hixie

    removed this from the None.This milestone has been deleted milestone on Aug 17, 2020
17. goderbauer commented on Feb 19, 2021

    

    goderbauer

    on Feb 19, 2021

    Member

    More actions

    Not disposing these recognizers is actually causing crashes in the RenderToggleable. I've filed #76411 with details.
18. exaby73 commented on Apr 17, 2023

    

    exaby73

    on Apr 17, 2023

    Member

    More actions

    #76745 removed RenderToggleable but _RenderCupertinoSwitch and _RenderSlider still do not dispose of their TapGestureRecognizers. Updating the labels and removing RenderToggleable from the title to better reflect the current state of the issue.

    _RenderCupertinoSwitch

    flutter/packages/flutter/lib/src/cupertino/switch.dart

    Lines 664 to 667 in 858d4ff

    	void dispose() {
    	_clipRRectLayer.layer = null;
    	super.dispose();
    	}

    _RenderSlider

    flutter/packages/flutter/lib/src/cupertino/switch.dart

    Lines 664 to 667 in 858d4ff

    	void dispose() {
    	_clipRRectLayer.layer = null;
    	super.dispose();
    	}
19. exaby73

    added

    found in release: 3.10Found to occur in 3.10Found to occur in 3.10

    and removed

    found in release: 1.21Found to occur in 1.21Found to occur in 1.21

    on Apr 17, 2023
20. exaby73

    changed the title [-]TapGestureRecognizer leaked by RenderToggleable, _RenderCupertinoSwitch, _RenderSlider[/-] [+]TapGestureRecognizer leaked by `_RenderCupertinoSwitch`, `_RenderSlider`[/+] on Apr 17, 2023
21. exaby73

    changed the title [-]TapGestureRecognizer leaked by `_RenderCupertinoSwitch`, `_RenderSlider`[/-] [+]`TapGestureRecognizer` leaked by `_RenderCupertinoSwitch`, `_RenderSlider`[/+] on Apr 17, 2023
22. bleroux

    changed the title [-]`TapGestureRecognizer` leaked by `_RenderCupertinoSwitch`, `_RenderSlider`[/-] [+]`TapGestureRecognizer` leaked by `_RenderSlider` and `_RenderRangeSlider`[/+] on Apr 18, 2023
23. bleroux commented on Apr 18, 2023

    

    bleroux

    on Apr 18, 2023

    Last edited by bleroux

    Contributor

    More actions

    In #51606 the CupertinoSwitch was refactored to move the gesture recognizer out of the RenderObject into a state object.

    _RenderSlider and _RenderRangeSlider do not dispose their TapGestureRecognizer.

    👍React with 👍1Reacted by Nabeel Parkar
24. flutter-triage-bot

    added

    team-frameworkOwned by Framework teamOwned by Framework team

    triaged-frameworkTriaged by Framework teamTriaged by Framework team

    on Jul 8, 2023
25. AbdeMohlbi commented on Nov 12, 2026

    

    AbdeMohlbi

    on Nov 12, 2026

    Member

    More actions

    this seems to be fixed now because both _RenderRangeSlider and _RenderSlider do dispose their TapGestureRecognizer:

    _RenderRangeSlider
    

    flutter/packages/flutter/lib/src/material/range_slider.dart

    Lines 1291 to 1294 in 42cd7ee

    	@override
    	void dispose() {
    	_drag.dispose();
    	_tap.dispose();

    _RenderSlider
    

    flutter/packages/flutter/lib/src/material/slider.dart

    Lines 1548 to 1552 in 42cd7ee

    	@override
    	void dispose() {
    	_drag.dispose();
    	_tap.dispose();
    	_labelPainter.dispose();