Skip to content

Add an integration test for Android+OpenGL external textures #141973

@matanlurey

Description

@matanlurey

Due to repository structure (the engine lives in flutter/engine, and the framework lives in flutter/flutter), it is [not possible for me to atomically write and update a (good) test]1 in flutter/engine#49938.

This issue is to track adding a test in a [follow-up PR]2.

Footnotes

  1. Much has been said and re-said about the repo structure making good engine testing hard. For example, if I want to write code the same way an end-user would (i.e. a plugin, and register textures, etc), I really need the full flutter framework available, which it is not in flutter/engine.

  2. It's theoretically possible to write a test first, but the test would immediately start failing (and turn the flutter/flutter tree red) once the engine patch is written. To avoid pain for all Flutter contributors, I'll just take the pain myself I suppose.

Metadata

Metadata

Assignees

Labels

P1High-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.e: impellerImpeller rendering backend issues and features requestsengineflutter/engine related. See also e: labels.fyi-androidFor the attention of Android platform teamplatform-androidAndroid applications specificallyr: duplicateIssue is closed as a duplicate of an existing issueteam-engineOwned by Engine teamtriaged-engineTriaged by Engine team

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions