Golden file testing for flutter/flutter is unreliable #141880
Description
#140101 introduced a regression that causes failures at head to not break the tree.
Because of this, there is no enforcement of approved/unapproved images right now for flutter/flutter.
The revert is currently blocked.
- Revert: Revert "Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal (#140101)" #141814
- Blocked by Unpin test, test_api and test_core in flutter. #140169
Until resolved, contributors should consider refraining from introducing image changes. If necessary, i.e. from an engine roll, please check https://flutter-gold.skia.org/ after the change lands to ensure any new images or updated images are properly approved. Otherwise changes may cascade down to other PRs looking for approval.
We do have a safety net of sorts against regressions due to extensive golden file testing inside of Google, which is executed when Flutter rolls into Google.