-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
flutter/packages
#5938Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyplatform-macBuilding on or for macOS specificallyBuilding on or for macOS specificallyteam-ecosystemOwned by Ecosystem teamOwned by Ecosystem team
Description
Running swift-format over the Pigeon-generated output turned up a bunch of places where our generator output doesn't match formatted output. While we don't need it to be perfectly formatted, we do generally want to match expected style in the initial generation. And in a number of cases, the output is distinctly non-idiomatic, like parens in if statements.
Some things to fix based on initial skim (but when doing this we should iterate a bit with the autoformatter and try to fix anything that's relatively straightforward):
ifstatements should not use()s.cases should not be indented relative to theswitch- Conditional imports should be indented
- Multi-line arrays should use trailing commas
- Named params should have a space after
:, which is missing in some places
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projectp: pigeonrelated to pigeon messaging codegen toolrelated to pigeon messaging codegen toolpackageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.platform-iosiOS applications specificallyiOS applications specificallyplatform-macBuilding on or for macOS specificallyBuilding on or for macOS specificallyteam-ecosystemOwned by Ecosystem teamOwned by Ecosystem team