showSnackBar is always replacing animation parameter of SnackBar #141646
Description
Steps to reproduce
- Use the code below and set the
durationto 5 second - click the button to show the
SnackBar - This issues is caused by the code in the implementation of
showSnackBarbelow
- flutter/lib/material/scaffold.dart
It always replaces the AnimationController in the SnackBar by creating a new controller. I am not sure if this was the design purpose, but it is weird that exposed animation parameter and two methods to developer without warning. Only one line of comment about the static method usage:
// API for ScaffoldMessengerState.showSnackBar():
/// Creates an animation controller useful for driving a snack bar's entrance and exit animation.
static AnimationController createAnimationController({ required TickerProvider vsync }) {
return AnimationController(
duration: _snackBarTransitionDuration,
debugLabel: 'SnackBar',
vsync: vsync,
);
}It is proposed that either to add comment the animation, createAnimationController and withAnimation as private API or provide a optional parameter to showSnackBar to allow develop to custom the enter and exit animation
ScaffoldFeatureController<SnackBar, SnackBarClosedReason> showSnackBar(
SnackBar snackBar,
{AnimationController? animationController}) {
assert(
_scaffolds.isNotEmpty,
'ScaffoldMessenger.showSnackBar was called, but there are currently no '
'descendant Scaffolds to present to.',
);
_snackBarController ??= (animationController ??
SnackBar.createAnimationController(vsync: this))
..addStatusListener(_handleSnackBarStatusChanged);Expected results
The entrance animation of the SnackBar take 5 seconds.
Actual results
What ever you change the configuration of the controller, it will never change the animation.
Code sample
class TestPage extends StatefulWidget {
const TestPage({super.key});
@override
State<TestPage> createState() => _TestPageState();
}
class _TestPageState extends State<TestPage>
with SingleTickerProviderStateMixin {
late final AnimationController _animationController;
late final Animation<double> _animation;
@override
void initState() {
super.initState();
_animationController =
AnimationController(vsync: this, duration: const Duration(seconds: 5));
_animation =
CurvedAnimation(parent: _animationController, curve: Curves.easeInOut);
}
@override
void dispose() {
_animationController.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: TextButton(
onPressed: () {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(
behavior: SnackBarBehavior.floating,
animation: _animation,
content: const Text('Hello Suica'),
),
);
},
child: const Text('Press to show snack bar')),
),
);
}
}Screenshots or Video
Screenshots / Video demonstration
[Upload media here]
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-01-16.at.22.11.25.mp4
Logs
Logs
[Paste your logs here]Flutter Doctor output
[✓] Flutter (Channel stable, 3.16.7, on macOS 14.1 23B74 darwin-x64, locale en-GB)
• Flutter version 3.16.7 on channel stable at /Users/suica/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision ef1af02aea (5 days ago), 2024-01-11 15:19:26 -0600
• Engine revision 4a585b7929
• Dart version 3.2.4
• DevTools version 2.28.5
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /Users/suica//Library/Android/sdk
• Platform android-34, build-tools 34.0.0
• ANDROID_HOME = /Users/suica//Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 15C500b
• CocoaPods version 1.13.0
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2023.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
[✓] IntelliJ IDEA Ultimate Edition (version 2020.1.4)
• IntelliJ at /Applications/IntelliJ IDEA.app
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] VS Code (version 1.85.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.80.0
[✓] Connected device (4 available)
• iPhone 15 Pro Max (mobile) • • ios • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
• macOS (desktop) • macos • darwin-x64 • macOS 14.1 23B74 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 120.0.6099.216
[✓] Network resources
• All expected network resources are available.Metadata
Metadata
Assignees
Labels
Type
Projects
Status