You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Impeller] SurfaceTextures created by some critical plugins do not render in OpenGL. #141636
@bdero (who did a bunch of the OES Impeller plumbing work) could something have regressed in the OES code paths? I know we had to rewrite shaders and there were other complications in Impeller. AFAIK, this code is not tested today.
changed the title [-]`SurfaceTexture`s created by some critical plugins do not render in Impeller+OpenGL[/-][+][Impeller] `SurfaceTexture`s created by some critical plugins do not render in OpenGL.[/+]on Jul 3, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.
Activity
matanlurey commentedon Jan 16, 2024
I checked an assumption that potentially frames aren't being pumped:
... but it is:
matanlurey commentedon Jan 16, 2024
Ok I appear to have narrowed it down to something, TBD if this is the problem or not:
There is no representation of
kTextureExternalOESwithinimpeller::TextureGLES. That is, despite this:... it's later interpreted as
A8UNormInt(maybe OK, maybe not) andTexture2D(not OK). Will investigate further.(See flutter-team-archive/engine#44559)
matanlurey commentedon Jan 16, 2024
Ok that above bit might be a false flag. I can confirm this code branch is never executed though:
Found with this patch:
johnmccutchan commentedon Jan 17, 2024
@bdero (who did a bunch of the OES Impeller plumbing work) could something have regressed in the OES code paths? I know we had to rewrite shaders and there were other complications in Impeller. AFAIK, this code is not tested today.
60 remaining items
matanlurey commentedon Mar 28, 2024
OpenGL + Impeller is no longer a priority. Downgrading.
[-]`SurfaceTexture`s created by some critical plugins do not render in Impeller+OpenGL[/-][+][Impeller] `SurfaceTexture`s created by some critical plugins do not render in OpenGL.[/+][Impeller] fix OES texture usage. (flutter-team-archive#55331)
github-actions commentedon Oct 8, 2024
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.Change how OpenGL textures are flipped in the Android embedder. (flut…
[Impeller] fix OES texture usage. (flutter-team-archive/engine#55331)