Skip to content

Chips delete button hover style is square, not circular #141335

@parlough

Description

@parlough

Steps to reproduce

  1. Have an InputChip with an onDeleted handler and M3 enabled.
  2. Run the app. (I tried macos, CanvasKit, and skwasm)
  3. Hover over the delete button (X) of the InputChip

Expected results

The hover state should result in a circular shape according to the M3 spec. I feel that would also look better.

It seems this affects the focus state for the delete button as well.

Actual results

The hover state results in a square shape.

Showcase that hover state is square

Code sample

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: InputChip(
            label: Text('Test'),
            onPressed: () {},
            onDeleted: () {},
          ),
        ),
      ),
    );
  }
}

Screenshots

Screenshot Showcase that hover state is square

Flutter info

Flutter version
Flutter 3.19.0-3.0.pre.43 • channel main • https://github.com/flutter/flutter
Framework • revision f961fdf2ba (4 hours ago) • 2024-01-10 17:37:07 -0500
Engine • revision a045134c91
Tools • Dart 3.4.0 (build 3.4.0-14.0.dev) • DevTools 2.31.0

Metadata

Metadata

Assignees

Labels

P2Important issues not at the top of the work listf: material designflutter/packages/flutter/material repository.found in release: 3.16Found to occur in 3.16found in release: 3.19Found to occur in 3.19frameworkflutter/packages/flutter repository. See also f: labels.has reproducible stepsThe issue has been confirmed reproducible and is ready to work onr: fixedIssue is closed as already fixed in a newer versionteam-designOwned by Design Languages teamtriaged-designTriaged by Design Languages team

Type

No type

Projects

Status

Done (PR merged)

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions