-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecttoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.
Description
I recently tried to run flutter upgrade because I was prompted to:
Building flutter tool...
╔════════════════════════════════════════════════════════════════════════════╗
║ WARNING: your installation of Flutter is 45 days old. ║
║ ║
║ To update to the latest version, run "flutter upgrade". ║
╚════════════════════════════════════════════════════════════════════════════╝
Running "flutter packages get" in catalog...
(code/flutter:traversal) -- flutter > flutter upgrade
Unable to upgrade Flutter: no upstream repository configured.
(code/flutter:traversal) -- flutter > git remote -v
origin [email protected]:gspencergoog/flutter.git (fetch)
origin [email protected]:gspencergoog/flutter.git (push)
upstream [email protected]:flutter/flutter.git (fetch)
upstream [email protected]:flutter/flutter.git (push)
And because my branch wasn't branched from flutter/flutter.git, but rather from gspencergoog/flutter.git, flutter upgrade errored out without telling me anything about what I should do, how I could fix it, or why it failed. This seems like a case specific to people who work on the flutter project, but really anyone who forks flutter for any reason will encounter it eventually.
We should:
- Not warn about stale installs for forked repos
- Fail to run
flutter upgradein a forked repo branch, or, alternatively - Make
flutter upgradedo something useful in a forked repo branch and not error out. - At the very least, change the error message so that it is truthful (I did have an upstream repo configured, it just didn't match with the origin).
pulyaevskiy, willlarche, kevmoo, christopherfujino and jdeltoft
Metadata
Metadata
Assignees
Labels
P3Issues that are less important to the Flutter projectIssues that are less important to the Flutter projecttoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.